<html><head></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space; ">Hello,<div><br></div><div>I have found some bugs while packaging noPoll for ArchLinux. I have the same bugs on OS X.</div><div><br></div><div>First, autogen.sh is producing some warnings, which are treated as errors :</div><div><div><font class="Apple-style-span" face="Monaco"><span class="Apple-tab-span" style="white-space:pre"> </span>configure.ac:47: warning: AM_INIT_AUTOMAKE: two- and three-arguments forms are deprecated. For more info, see:</font></div><div><font class="Apple-style-span" face="Monaco"><span class="Apple-tab-span" style="white-space:pre"> </span>configure.ac:47: <a href="http://www.gnu.org/software/automake/manual/automake.html#Modernize-AM_005fINIT_005fAUTOMAKE-invocation">http://www.gnu.org/software/automake/manual/automake.html#Modernize-AM_005fINIT_005fAUTOMAKE-invocation</a></font></div><div><font class="Apple-style-span" face="Monaco"><span class="Apple-tab-span" style="white-space:pre"> </span>src/Makefile.am:7: warning: 'INCLUDES' is the old name for 'AM_CPPFLAGS' (or '*_CPPFLAGS')</font></div><div><font class="Apple-style-span" face="Monaco"><span class="Apple-tab-span" style="white-space:pre"> </span>test/Makefile.am:8: warning: 'INCLUDES' is the old name for 'AM_CPPFLAGS' (or '*_CPPFLAGS')</font></div></div><div><br></div><div>Also, the '--Werror' flag is not defined for autoconf :</div><div><div><font class="Apple-style-span" face="Monaco"><span class="Apple-tab-span" style="white-space:pre"> </span>automake: error: unrecognized option '--Werror'.</font></div></div><div>'-Werror' should be used.</div><div><br></div><div>And finally, there is a problem for headers : they are installed in …<font class="Apple-style-span" face="Monaco">/include/nopoll</font>, but, in the headers, <font class="Apple-style-span" face="Monaco">#include <nopoll_[…].h></font> is used, so the compiler can't find it.</div><div>Maybe the includes should me prefixed with '<font class="Apple-style-span" face="Monaco">nopoll/</font>', like this : <font class="Apple-style-span" face="Monaco">#include <nopoll/nopoll_[…].h></font></div><div><br></div><div>Regards</div><div><div>
<div style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space; "><div><hr><pre>Félix Faisant</pre></div></div>
</div>
<br></div></body></html>