<html xmlns:v="urn:schemas-microsoft-com:vml" xmlns:o="urn:schemas-microsoft-com:office:office" xmlns:w="urn:schemas-microsoft-com:office:word" xmlns:m="http://schemas.microsoft.com/office/2004/12/omml" xmlns="http://www.w3.org/TR/REC-html40"><head><meta http-equiv=Content-Type content="text/html; charset=utf-8"><meta name=Generator content="Microsoft Word 14 (filtered medium)"><style><!--
/* Font Definitions */
@font-face
{font-family:Calibri;
panose-1:2 15 5 2 2 2 4 3 2 4;}
@font-face
{font-family:Tahoma;
panose-1:2 11 6 4 3 5 4 4 2 4;}
@font-face
{font-family:Consolas;
panose-1:2 11 6 9 2 2 4 3 2 4;}
/* Style Definitions */
p.MsoNormal, li.MsoNormal, div.MsoNormal
{margin:0cm;
margin-bottom:.0001pt;
font-size:12.0pt;
font-family:"Times New Roman","serif";}
a:link, span.MsoHyperlink
{mso-style-priority:99;
color:blue;
text-decoration:underline;}
a:visited, span.MsoHyperlinkFollowed
{mso-style-priority:99;
color:purple;
text-decoration:underline;}
pre
{mso-style-priority:99;
mso-style-link:"HTML Preformatted Char";
margin:0cm;
margin-bottom:.0001pt;
font-size:10.0pt;
font-family:"Courier New";}
span.HTMLPreformattedChar
{mso-style-name:"HTML Preformatted Char";
mso-style-priority:99;
mso-style-link:"HTML Preformatted";
font-family:"Consolas","serif";}
span.EmailStyle19
{mso-style-type:personal-reply;
font-family:"Calibri","sans-serif";
color:#1F497D;}
.MsoChpDefault
{mso-style-type:export-only;
font-size:10.0pt;}
@page WordSection1
{size:612.0pt 792.0pt;
margin:72.0pt 72.0pt 72.0pt 72.0pt;}
div.WordSection1
{page:WordSection1;}
--></style><!--[if gte mso 9]><xml>
<o:shapedefaults v:ext="edit" spidmax="1026" />
</xml><![endif]--><!--[if gte mso 9]><xml>
<o:shapelayout v:ext="edit">
<o:idmap v:ext="edit" data="1" />
</o:shapelayout></xml><![endif]--></head><body lang=EN-GB link=blue vlink=purple><div class=WordSection1><p class=MsoNormal><span style='font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1F497D'>Hi Francis,<o:p></o:p></span></p><p class=MsoNormal><span style='font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1F497D'><o:p> </o:p></span></p><p class=MsoNormal><span style='font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1F497D'>Thanks for your quick reply. I didn’t have logging enabled, because it produces a lot of output!<o:p></o:p></span></p><p class=MsoNormal><span style='font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1F497D'><o:p> </o:p></span></p><p class=MsoNormal><span style='font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1F497D'>If there was a way to enable logging only for messages over a certain level, that would be useful. I know I could write my own handler which could do the filtering. I may do that anyway.<o:p></o:p></span></p><p class=MsoNormal><span style='font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1F497D'><o:p> </o:p></span></p><p class=MsoNormal><span style='font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1F497D'>Thanks<o:p></o:p></span></p><p class=MsoNormal><span style='font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1F497D'>Tony<o:p></o:p></span></p><p class=MsoNormal><span style='font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1F497D'><o:p> </o:p></span></p><div><div style='border:none;border-top:solid #B5C4DF 1.0pt;padding:3.0pt 0cm 0cm 0cm'><p class=MsoNormal><b><span lang=EN-US style='font-size:10.0pt;font-family:"Tahoma","sans-serif"'>From:</span></b><span lang=EN-US style='font-size:10.0pt;font-family:"Tahoma","sans-serif"'> Francis Brosnan Blázquez [mailto:francis.brosnan@aspl.es] <br><b>Sent:</b> 19 September 2017 12:24<br><b>To:</b> Tony Mountifield<br><b>Cc:</b> nopoll@lists.aspl.es<br><b>Subject:</b> Re: [noPoll] nopoll_loop_wait(ctx,0) unexpectedly exited<o:p></o:p></span></p></div></div><p class=MsoNormal><o:p> </o:p></p><p class=MsoNormal style='margin-bottom:12.0pt'>Hello Tony.<br><br>I've been reviewing this and the only way for nopoll_loop_wait to<br>stop/return is to have an error at:<br><br><a href="https://github.com/ASPLes/nopoll/blob/master/src/nopoll_loop.c#L237">https://github.com/ASPLes/nopoll/blob/master/src/nopoll_loop.c#L237</a><br>(ctx->io_engine->wait returning error)<br><br>...or timeout reached (which is not your case):<br><br><a href="https://github.com/ASPLes/nopoll/blob/master/src/nopoll_loop.c#L259">https://github.com/ASPLes/nopoll/blob/master/src/nopoll_loop.c#L259</a><br><br>So, I think there must have been some error while waiting (because some<br>socket was in a non-consistent state or something..). I assume you<br>don't the log reporting such failure so we can better know error<br>reported, right?:<o:p></o:p></p><p class=MsoNormal style='margin-bottom:12.0pt'><span style='color:blue'><a href="https://github.com/ASPLes/nopoll/blob/master/src/nopoll_loop.c#L238">https://github.com/ASPLes/nopoll/blob/master/src/nopoll_loop.c#L238</a></span><br><br><span style='color:blue'><a href="https://github.com/ASPLes/nopoll/blob/master/src/nopoll_loop.c#L238nopoll_log">nopoll_log</a> (ctx, NOPOLL_LEVEL_CRITICAL, "Received error from wait operation, error code was: %d", errno);</span><o:p></o:p></p><p class=MsoNormal>Anyway, reviewing this case I think it would be useful to have<br>nopoll_loop_wait to report an error code that indicates these failures<br>so you can react by calling nopoll_loop_init code in case of ->wait<br>failure to recover. I'm going to review this.<br><br>Best Regards.<br><br><br>El mar, 19-09-2017 a las 10:51 +0000, Tony Mountifield escribió: <o:p></o:p></p><pre><o:p> </o:p></pre><pre>I just had a strange occurrence, and wondered how to go about understanding it.<o:p></o:p></pre><pre><o:p> </o:p></pre><pre>I have a websocket thread that calls nopoll_loop_wait(ctx,0), which I expected<o:p></o:p></pre><pre>to continue running until another thread calls nopoll_loop_stop(ctx) as part<o:p></o:p></pre><pre>of the process termination.<o:p></o:p></pre><pre><o:p> </o:p></pre><pre>Today, while testing, nopoll_look_wait() had been running fine, but then exited<o:p></o:p></pre><pre>when I closed one of the accepted connections. I hadn't captured the return status,<o:p></o:p></pre><pre>but will add code to do that for next time.<o:p></o:p></pre><pre><o:p> </o:p></pre><pre>I am certain nopoll_loop_stop() had not been called, so I was wondering if there<o:p></o:p></pre><pre>is any other reason nopoll_loop_wait(ctx,0) would exit after running fine for a time?<o:p></o:p></pre><pre><o:p> </o:p></pre><pre>I've only ever seen it happen the once.<o:p></o:p></pre><pre><o:p> </o:p></pre><pre>I'll dig into the code, but wanted to ask here for ideas!<o:p></o:p></pre><pre><o:p> </o:p></pre><pre>Thanks,<o:p></o:p></pre><pre>Tony<o:p></o:p></pre><p class=MsoNormal><o:p> </o:p></p></div></body></html>