[Vortex] Two problems

[Philip Kovacs]

Francis Brosnan Blazquez wrote:
> El lun, 12-06-2006 a las 19:00 -0400, Philip Kovacs escribió:
>
> Hi Phil,
>
>   
>> The first problem is in vortex_thread_pool.c:
>>
>> void vortex_thread_pool_exit ()
>> {
>>         g_log (LOG_DOMAIN, G_LOG_LEVEL_DEBUG, "stopping thread
>> pool..");
>>
>>         g_thread_pool_free (__vortex_thread_pool,
>>                             TRUE, /* not immediatly */
>> <--- 
>> FALSE
>>                             TRUE); /* wait until all threads are ready
>> */
>>
>>         g_log (LOG_DOMAIN, G_LOG_LEVEL_DEBUG, "thread pool is
>> stopped..");
>>         return;
>> }
>>
>> You should use FALSE for not immediately, not TRUE.
>>     
>
> Why do think it should be FALSE?
>
>   

Only because your comment /* not immediately */ indicated to me that 
*you* wish to process all
pending tasks.  If that is indeed your desire, you must not use TRUE.

http://developer.gnome.org/doc/API/2.0/glib/glib-Thread-Pools.html#g-thread-pool-free