[Vortex] Patch: Use "const" appropriately in API; add logging mutex
Francis Brosnan Blazquez
francis at aspl.es
Tue Dec 18 20:04:20 CET 2007
> > 3) vortex_frame_get_error_message code parameter was not updated
> > use
> > const char *.
> It shouldn't return a const pointer, because the string has to be
> freed by the caller.
Yap, i meant the code parameter received (not the data returned by the
> > In the same direction, having this activated makes the global
> > execution to behave in a really different way (than executing
> > log) because all threads are synchronized by log calls
> That's true, I hadn't considered how that could affect the behavior
> the program. I agree that turning on the mutex should be optional,
> Thanks for taking the patch and for your additional work!
> One more minor change I'd like to make: Allow the "log level" to be
> configured, so that for example I could reduce the verbosity by
> turning on 'warning' but not 'debug' level logging.
Sounds like a good a idea Jens..
> It's probably
> best, then, if I check out top-of-tree from SVN and submit a patch
> based on that, to avoid a lot of merging on your end.
Francis Brosnan Blazquez <francis at aspl.es>
Advanced Software Production Line, S.L.
More information about the Vortex