[Vortex] [PATCH] sanitize vortex_connection_*

Benoit Amiaux b.amiaux at ateme.com
Wed Jan 23 09:40:29 CET 2008


Francis Brosnan Blazquez wrote:
> No you didn't. There is a bug in the connection timeout code which mixes
> microseconds value from vortex_connection_get_connect_timeout and the
> value returned by time. 
> 
> Because vortex_connection_get_connect_timeout (and _get_timeout) must
> return microseconds, I've updated this code to convert the value
> returned into seconds so it is now compatible with time(). Updated both
> branches.

Btw, your patch is still incomplete as vortex_connection.h mentions 
vortex_connection_connect_timeout use seconds as input and set the value 
as seconds while vortex_connection_get_connect_timeout will assume the 
value is in microseconds.

Thanks,

-- 
Amiaux Benoît - b.amiaux at ateme.com



More information about the Vortex mailing list