[Vortex] [BUG] Race condition in vortex_remove_on_close_full

[AMIAUX Benoît]

Hello,

I have a race condition in vortex_connection_remove_on_close_full
Looking at the code, it seems that the access to the axl_list connection::on_close_full is not protected inside __vortex_connection_invoke_on_close
Attached patch locks handlers_mutex before calling the handler, however I am not sure whether it is good behavior to call an external callback while being locked inside vortex.

Any comments ?

Benoît Amiaux

Ce message et toutes les pièces jointes sont confidentiels et établis à l'intention exclusive de ses destinataires. Toute modification, édition, utilisation ou diffusion non autorisée est interdite. Si vous avez reçu ce message par erreur, merci de nous en avertir immédiatement. ATEME décline toute responsabilité au titre de ce message s'il a été altéré, déformé, falsifié ou encore édité ou diffusé sans autorisation.
This message and any attachments are confidential and intended solely for the addressees. Any unauthorized modification, edition, use or dissemination is prohibited. If you have received this message by mistake, please notify us immediately. ATEME decline all responsibility for this message if it has been altered, deformed, falsified or even edited or disseminated without authorization.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: lock_invoke_on_close.patch
Type: application/octet-stream
Size: 579 bytes
Desc: lock_invoke_on_close.patch
URL: <http://lists.aspl.es/pipermail/vortex/attachments/20100818/0093d276/attachment.obj>