[noPoll] Some package-related bugs

[Félix]

Le 31 oct. 2014 à 11:25, Francis Brosnan Blázquez a écrit :

> On jue, 2014-10-30 at 03:21 +0100, Félix wrote:
>> Hello,
> 
> Hi Félix,
> 
>> I have found some bugs while packaging noPoll for ArchLinux. I have the same bugs on OS X.
> 
> Ok,
> 
>> First, autogen.sh is producing some warnings, which are treated as errors  :
>> configure.ac:47: warning: AM_INIT_AUTOMAKE: two- and three-arguments forms are deprecated.  For more info, see:
>> configure.ac:47: http://www.gnu.org/software/automake/manual/automake.html#Modernize-AM_005fINIT_005fAUTOMAKE-invocation
>> src/Makefile.am:7: warning: 'INCLUDES' is the old name for 'AM_CPPFLAGS' (or '*_CPPFLAGS')
>> test/Makefile.am:8: warning: 'INCLUDES' is the old name for 'AM_CPPFLAGS' (or '*_CPPFLAGS')
> 
> Uhmn...I don't these errors on debian wheezy, debian squeeze, ubuntu precise and other distributions.... :-?

I'm using 'autoconf (GNU Autoconf) 2.69', 'automake (GNU automake) 1.14' and 'm4 (GNU M4) 1.4.17' on OS X and ArchLinux. I don't have other distributions.

> I've tried to update these value to the provided indications but I'm getting lot of m4/autoconf errors... :-?
> Maybe you could provide a patch that I can test easily...

In both Makefile.am, I changed 'INCLUDES' to 'AM_CPPFLAGS' and I have no problem.
For the configure.ac, I changed

------------------
AC_INIT(src/nopoll.h)

configure_dir=`dirname "$0"`
NOPOLL_VERSION=`cat $configure_dir/VERSION`
AC_SUBST(NOPOLL_VERSION)

AC_CONFIG_AUX_DIR(.)
AM_INIT_AUTOMAKE(nopoll, $NOPOLL_VERSION)
AM_CONFIG_HEADER(config.h)
AM_MAINTAINER_MODE
------------------

to

------------------
AC_INIT(nopoll, m4_esyscmd([cat `dirname "$0"`/VERSION | tr -d '\n']))
NOPOLL_VERSION=$VERSION
AC_SUBST(NOPOLL_VERSION)
AM_INIT_AUTOMAKE
AC_CONFIG_SRCDIR([src/nopoll.h])
AM_CONFIG_HEADER(config.h)
AM_MAINTAINER_MODE
------------------

I tested on ArchLinux and I have no more problems, making went fine too. A patch is attached.


>> Also, the '--Werror' flag is not defined for autoconf :
>> automake: error: unrecognized option '--Werror'.
>> '-Werror' should be used.
> 
> Fixed,
> 
>> And finally, there is a problem for headers : they are installed in …/include/nopoll, but, in the headers, #include <nopoll_[…].h> is used, so the compiler can't find it.
>> Maybe the includes should me prefixed with 'nopoll/', like this : #include <nopoll/nopoll_[…].h>
> 
> Ok, for this to work, you have to use pkg-config, that is, running the following will give you the right includes:
> 
> >> pkg-config --cflags nopoll
> -I/usr/include/nopoll  
> 
> More info at: http://www.aspl.es/nopoll/html/nopoll_core_library_manual.html#using_nopoll

Oh, sorry, I should have thought of that !

> Thanks for reporting Félix :-) Best Regards

Have a good day !

Félix Faisant

------------ próxima parte ------------
Se ha borrado un adjunto en formato HTML...
URL: <http://lists.aspl.es/pipermail/nopoll/attachments/20141031/51bb051b/attachment.html>
------------ próxima parte ------------
A non-text attachment was scrubbed...
Name: configure.ac.patch
Type: application/octet-stream
Size: 534 bytes
Desc: no disponible
URL: <http://lists.aspl.es/pipermail/nopoll/attachments/20141031/51bb051b/attachment.obj>
------------ próxima parte ------------
Se ha borrado un adjunto en formato HTML...
URL: <http://lists.aspl.es/pipermail/nopoll/attachments/20141031/51bb051b/attachment-0001.html>