[Vortex] xml-rpc API bug

[Francis Brosnan Blazquez]

El mar, 03-04-2007 a las 12:49 +0200, milton.yates at loule.info escribió:
> hi,

Hi Milton,

> I've found, what I think is, an inconsistency in the API:
> 
> * vortex_xml_rpc_accept_negociation proposes to pass user_data to the
> "VortexXmlRpcValidateResource validate_resource" callback, via its
> second parameter.
> 
> BUT
> 
> * type VortexXmlRpcValidateResource is:
> bool(*) VortexXmlRpcValidateResource(VortexConnection *connection, int
> channel_number, char *serverName, char *resource_path)
> --> it has NO user_data parameter !

You are right, there is a bug in the function signature. It must receive
a user defined pointer.

> this is most likely an inconsistency and can get annoying.
> 
> I suppose an API change would be required for
> VortexXmlRpcValidateResource to include the void* (AxlPointer) pointer
> in its parameters.

I think, in this particular case we can safely change the API by
extending the missing parameter. Would you take on the patch? Let me
know it.

Thanks for reporting Milton!

> Bye,
> Milton. 
-- 
Francis Brosnan Blazquez <francis at aspl.es>
Advanced Software Production Line, S.L.