[Vortex] [PATCH] fix vortex threads and vortex_exit

Francis Brosnan Blazquez francis at aspl.es
Mon Dec 10 15:52:51 CET 2007


Hi,

> Please note that this patch only work if the axl list implementation
> is 
> also fixed. Currently, when axl_list_always_return_1 is used as the 
> equal function (and that's what the thread pool use), axl_list_remove
> is 
> unable to remove any item, and so unable to call the release function
> on 
> list nodes (and so threads never get released).

I see the issue you point, calling to axl_list_remove on lists
configured with axl_list_always_return_1 will cause the destroy function
to be never called if axl_list_remove and axl_list_unlink are used. 

However, i'm still not able to see how this affect to the thread pool
releasing since axl_list_remove or axl_list_unlink aren't used..

> Furthermore, the thread patch I gave previously was missing a 
> pthread_attr_destroy. I attached a patch against svn trunk for it.

Good,

> > Hi Amiaux
> Minor nitpick, but I believe you want to say "Hi Benoit" instead ;)

Sorry for the confusion ;-) Cheers!

> Bye,
> AMIAUX Benoit

-- 
Francis Brosnan Blazquez <francis at aspl.es>
Advanced Software Production Line, S.L.




More information about the Vortex mailing list