[Vortex] BUG: Vortex sends messages with incorrect syntax

[Jens Alfke]

On 9 May '08, at 10:43 AM, I wrote:

> It would be trivial to fix this by making  
> vortex_frame_build_up_from_params_s always add the CRLF before the  
> payload.

...but maybe not. I looked at this, and it appears that this function  
gets called for every frame — even the ones resulting from fragmented  
messages. In that case, the headers or CRLF should not be added to the  
subsequent frames; but the function has no way of knowing whether  
that's the case.

Vortex itself only calls it from one place in the sequencer, where it  
does know whether this is a piece of a fragmented message, so it would  
be possible to add a new boolean parameter to  
vortex_frame_build_up_from_params_s; but that involves an API change  
since that function is public.

—Jens
-------------- next part --------------
A non-text attachment was scrubbed...
Name: smime.p7s
Type: application/pkcs7-signature
Size: 1875 bytes
Desc: not available
Url : http://lists.aspl.es/pipermail/vortex/attachments/20080509/b6911a3f/attachment.bin