[Vortex] win2K and Channel DTD

[DE JAGER Frédéric NAN]

Hello again,



The _CRT_SECURE_NO_DEPRECATE define is only present to avoid messages like :

1>.\axl_stream.c(2435) : warning C4996: '_vsnprintf' was declared deprecated
1>        D:\Program Files\Microsoft Visual Studio 8\VC\include\stdio.h(339)
: see declaration of '_vsnprintf'
1>        Message: 'This function or variable may be unsafe. Consider using
_vsnprintf_s instead. To disable deprecation, use _CRT_SECURE_NO_DEPRECATE.
See online help for details.'

In fact I missed the axl_config_win32.h file :)

I'll rebuild using it and check the regression test.

Concerning the change in behaviour I suppose it's due to the way vsnprintf
is implemented in the CRT but as now I'm quite unsure of the real reason.

Cheers
Fred

-----Message d'origine-----
De : Francis Brosnan Blazquez [mailto:francis at aspl.es] 
Envoyé : mercredi 8 octobre 2008 10:23
À : DE JAGER Frédéric NAN
Cc : vortex at lists.aspl.es
Objet : RE: [Vortex] win2K and Channel DTD

> Hello Francis,

Hi Fred,

> I'm using the binary distribution of LibVortex (version 1.0.15)
> 
> I narrowed the trouble to a probable bad behaviour in the functions
> axl_stream_strdup_printfv and axl_stream_strdup_printf_len which look
> to
> behave differently on Win2K than XP.

Ok.

> To have a correct behaviour I did rebuild LibAxl using the Visual C++
> solution but modified the it:
> 
> In the axl_config.h I file I commented the following lines 
> //#define AXL_OS_UNIX (0)
> //#define AXL_HAVE_VASPRINTF (0)
> As my target platform is WIN32 and not using gcc it make sense :)

;-) Ok. Just to note inside the distribution it is included a static
version of axl_config.h for the windows platform: axl_config_win32.h.
You only need to rename it to axl_config.h during the compile process. 

> Next I've modified the project properties:
> 
> I added the following preprocessor definitions :
> _CRT_SECURE_NO_DEPRECATE (to get ride of the junk produced by visual
> about
> deprecated functions)
> AXL_OS_WIN32 

OK.

> It seems to work but as I'm not the dev. using your lib I don't really
> know
> if it can break things as I've no idea of potential side effect.

To check if your axl build is right, you can use the regression test
located at test/test_01.c. Inside the windows installer, it is also
included. 

However, I don't see which is the change that makes your build to work.
It is a matter of the compiler? or because adding
_CRT_SECURE_NO_DEPRECATE? Can you provide more details about this?

Thanks for reporting Fred. Cheers!

> Cheers
> Fred
-- 
Francis Brosnan Blazquez <francis at aspl.es>