[Vortex] [BUG] Possible bug with vortex_connection_remove_on_close_full

[Benoit Amiaux]

Hello,

Benoit Amiaux wrote:
> Benoit Amiaux wrote:
> I've attached a patch that fix that bug

That patch is incomplete and wrong. The issue is that axl_list is unable 
to release any item with some equal functions, like axl_list_always_return_1

Attached patch fix the issue properly by fixing 
axl_list_internal_linear_lookup.

I do believe axl_list API is broken though, as sometimes items are 
compared using the equal function, and sometimes using pointers.

However, if we do use the equal function, things like

__vortex_thread_pool->threads = axl_list_new (axl_list_always_return_1, 
__vortex_thread_pool_terminate_thread);

can never work. __vortex_thread_pool_terminate_thread can never be 
called as the equal function can never return true.

Bye,
AMIAUX Benoit
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: fix_axl_list_remove.patch
Url: http://lists.aspl.es/pipermail/vortex/attachments/20071207/3132f675/attachment.txt